Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd issue grouping #3787

Closed
michaelni opened this issue May 11, 2020 · 5 comments
Closed

Odd issue grouping #3787

michaelni opened this issue May 11, 2020 · 5 comments

Comments

@michaelni
Copy link
Contributor

Hi
It seems oss-fuzz is grouping many unrelated testcases in the same issues.
For example issue 20492
https://oss-fuzz.com/testcases?q=group%3A5741286006456320 had many linked to 20492
their similarity where maybe 1-3 lines of the stacktrace, but even from seperate fuzz targets

Another example is issue 20659 which still has unlrelated issues grouped together at the moment

The real problem is that these issues where not vissible from the notification mails so only when i looked at why the issues where still open after thinking that they had been fixed did i realize that there where multiple unrelated testcases hiding threre

@inferno-chromium
Copy link
Collaborator

This is probably because 2nd frame is too similar(something*decode_frame) and 3rd frame is same(decode_simple_internal).
decode_frame
decode_simple_internal

It is really hard problem to how to best group. If we dont group, we file duplicate bugs. In this case, once you fix a bug and its incorrect group variants are not fixed, we will file a new bug for them in a few days.

@michaelni
Copy link
Contributor Author

Is it possible to make grouped issues more vissible in mail notices ?
Or is there something i can do to stay more aware of this when primarly using the mail notices?

@inferno-chromium
Copy link
Collaborator

This is hard from implementation perspective (since groups get generated over time as we see new testcase). But on any testcase report, e.g. https://oss-fuzz.com/testcase-detail/5639509530378240, you can always check if this is part of a group, e.g. "Related: Group XYZ". You can click that link to see grouped testcases.
Can this decode_simple_internal be marked as inline function, then it will vanish from crash signature ?

@michaelni
Copy link
Contributor Author

Can this decode_simple_internal be marked as inline function, then it will vanish from crash signature ?

Thanks for the suggestion, i posted a patch doing that to ffmpeg-devel
https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200511224635.19071-1-michael@niedermayer.cc/

TimothyGu pushed a commit to FFmpeg/FFmpeg that referenced this issue May 12, 2020
This was suggested in
google/oss-fuzz#3787
to reduce the grouping errors by oss-fuzz

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
@michaelni
Copy link
Contributor Author

suggested change applied to FFmpeg

intel-media-ci pushed a commit to intel-media-ci/ffmpeg-cartwheel that referenced this issue May 19, 2020
This was suggested in
google/oss-fuzz#3787
to reduce the grouping errors by oss-fuzz

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants