Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opendal: fix environment problem #10814

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Conversation

dqhl76
Copy link
Contributor

@dqhl76 dqhl76 commented Aug 9, 2023

Fix the problem that opendal cannot init service
related PR on opendal side: apache/opendal#2824
/cc @Xuanwo

Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

dqhl76 is either the primary contact or is in the CCs list of projects/opendal.
dqhl76 has previously contributed to projects/opendal. The previous PR was #10794

projects/opendal/build.sh Outdated Show resolved Hide resolved
projects/opendal/build.sh Show resolved Hide resolved
@Xuanwo
Copy link

Xuanwo commented Aug 9, 2023

Maybe we can commit .fs.env directly and just copy them? So we can have a shell function by which just:

  • copy .<scheme>.env to $OUT/.<scheme>.env
  • copy fuzz to $OUT/fuzz_reader_<scheme>

Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
@dqhl76
Copy link
Contributor Author

dqhl76 commented Aug 9, 2023

Sure. Reorganized the files!

Copy link

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavidKorczynski DavidKorczynski merged commit 226e1ac into google:master Aug 9, 2023
15 checks passed
@dqhl76 dqhl76 deleted the opendal-fix-env branch August 9, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants