Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serenity: Use latest builder #11874

Merged
merged 3 commits into from
May 2, 2024
Merged

Conversation

maflcko
Copy link
Contributor

@maflcko maflcko commented Apr 30, 2024

No description provided.

@maflcko maflcko marked this pull request as draft April 30, 2024 18:32
Copy link

maflcko has previously contributed to projects/serenity. The previous PR was #11714

@maflcko
Copy link
Contributor Author

maflcko commented Apr 30, 2024

Not sure how to fix this, since the error can not be suppressed in the way I tried. cc @ADKaster

/src/serenity/Userland/Libraries/LibCore/Socket.cpp:382:5: error: missing field '__cmsg_data' initializer [-Werror,-Wmissing-field-initializers]
  382 |     };
      |     ^
1 error generated.

@ADKaster
Copy link
Contributor

Jeez this looks like a glibc version difference or some such. Our CI is on Ubuntu 22.04. I'll take a look at a project patch upstream.

@ADKaster
Copy link
Contributor

ADKaster commented May 1, 2024

@maflcko with SerenityOS/serenity#24175 I was able to get this working locally without the cxxflags warning change.

@maflcko maflcko marked this pull request as ready for review May 1, 2024 05:15
@maflcko
Copy link
Contributor Author

maflcko commented May 1, 2024

Nice. It worked here as well on the latest CI run.

@ADKaster
Copy link
Contributor

ADKaster commented May 1, 2024

fwiw the CFLAGS/CXXFLAGS workaround didn't work because our BuildFuzzers.sh script pushes CFLAGS/CXXFLAGS in order to build c++ code generators without fuzzers.

i.e. using the strategy outlined here: https://google.github.io/oss-fuzz/getting-started/new-project-guide/#temporarily-disabling-code-instrumentation-during-builds

Unfortunately the problem file is also built as a part of the "uninstrumented build" of code generators.

@DavidKorczynski DavidKorczynski merged commit 1c1a6a7 into google:master May 2, 2024
15 checks passed
@maflcko maflcko deleted the 2404-serenity- branch May 2, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants