monero: Use latest builder

[maflcko]

No description provided.

[github-actions]

maflcko has previously contributed to projects/monero. The previous PR was #11714

[maflcko]

cc @binaryFate Can you please take a look here? This requires bumping the boost version, I presume.

[maflcko]

cc @luigi1111 @moneromooo-monero or maybe one of you can take a look at the boost upgrade?

[selsta]

@maflcko I'll look into it

[selsta]

Just updating boost doesn't work unfortunately, I might have to try different versions or ask someone else who is more experienced.

[maflcko]

Yes, the fix would be to bump boost. Currently boost is downloaded from && curl -s -L -o boost_${BOOST_VERSION}.tar.bz2 https://downloads.getmonero.org/libs/boost_${BOOST_VERSION}.tar.bz2 \. So to fix it, one would have to upload a different boost version there, or change the download source. (Among possibly other changes)

[selsta]

I did update it to 1.80 and it fails

#8 30.41 /usr/local/bin/../include/c++/v1/__config:13:10: fatal error: '__config_site' file not found
#8 30.41    13 | #include <__config_site>
#8 30.41       |          ^~~~~~~~~~~~~~~
#8 30.41 1 error generated.

https://github.com/selsta/testrepo/actions/runs/9566788394/job/26372907450#step:3:843

I can also try newer or older versions.

[maflcko]

Yeah, you could try 1.79 for now. It may be needed to set -DBOOST_NO_CXX98_FUNCTION_BASE in the pre-processor.

For example via ... && ./b2 --build-type=minimal link=static runtime-link=static --with-chrono --with-date_time --with-filesystem --with-program_options --with-regex --with-serialization --with-system --with-thread --with-locale threading=multi threadapi=pthread cflags="$CFLAGS -DBOOST_NO_CXX98_FUNCTION_BASE" cxxflags="$CXXFLAGS -DBOOST_NO_CXX98_FUNCTION_BASE" stage

[maflcko]

Not sure why the last push wasn't fixing the build. Somehow -std=c++11 wasn't propagated properly?

[maflcko]

Looks like boost 1.84 (or 1.81) is enough to avoid the deprecated c++11 code and the need to specify -DBOOST_NO_CXX98_FUNCTION_BASE.

To work around the missing __config_site. You can manually copy it for now as a temporary workaround. Just add this before downloading boost:

RUN cp /usr/local/include/x86_64-unknown-linux-gnu/c++/v1/__config_site /usr/local/include/c++/v1/

Also ./b2 ... stage would have to be replaced by ./b2 ... install.

If it works for you as well, and you agree with the changes, you can go ahead and create a new pull request against the master branch here.

[selsta]

It did build the docker image correctly, it failed to run it but that appears to be unrelated. Will open a PR with the changes.

[selsta]

#12138

[selsta]

I don't have a Google account unfortunately to sign the CLA. Can you add the commit to this PR, or should I ask someone else from the monero project to open the PR?