Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerd: move clone instrumentation to oss_fuzz_build.sh #12080

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vishalRGurrala
Copy link

@vishalRGurrala vishalRGurrala commented Jun 18, 2024

containerd/containerd#10362
The above PR clones the instrumentation repo in oss_fuzz_build.sh

Copy link

google-cla bot commented Jun 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

vishalRGurrala is a new contributor to projects/containerd. The PR must be approved by known contributors before it can be merged. The past contributors are: samuelkarp, kzys, cji

@jonathanmetzman
Copy link
Contributor

Can you sign the CLA?

@jonathanmetzman
Copy link
Contributor

@kzys @samuelkarp @cji do you approve?

@@ -17,6 +17,6 @@
FROM gcr.io/oss-fuzz-base/base-builder-go
RUN apt-get update && apt-get install -y btrfs-progs libc-dev pkg-config libseccomp-dev gcc wget libbtrfs-dev
RUN git clone --depth 1 https://github.com/containerd/containerd
RUN git clone --depth=1 https://github.com/AdamKorcz/instrumentation
#RUN git clone --depth=1 https://github.com/AdamKorcz/instrumentation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the line rather than commenting it out.

@samuelkarp
Copy link
Contributor

@jonathanmetzman I'd like to see this running with the corresponding change containerd/containerd#10348 before approving. Thanks!

@jonathanmetzman
Copy link
Contributor

jonathanmetzman commented Jun 18, 2024

OK. Ping me here when youre approval is ready.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants