-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
containerd: move clone instrumentation to oss_fuzz_build.sh #12080
base: master
Are you sure you want to change the base?
containerd: move clone instrumentation to oss_fuzz_build.sh #12080
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
vishalRGurrala is a new contributor to projects/containerd. The PR must be approved by known contributors before it can be merged. The past contributors are: samuelkarp, kzys, cji |
Can you sign the CLA? |
@kzys @samuelkarp @cji do you approve? |
projects/containerd/Dockerfile
Outdated
@@ -17,6 +17,6 @@ | |||
FROM gcr.io/oss-fuzz-base/base-builder-go | |||
RUN apt-get update && apt-get install -y btrfs-progs libc-dev pkg-config libseccomp-dev gcc wget libbtrfs-dev | |||
RUN git clone --depth 1 https://github.com/containerd/containerd | |||
RUN git clone --depth=1 https://github.com/AdamKorcz/instrumentation | |||
#RUN git clone --depth=1 https://github.com/AdamKorcz/instrumentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the line rather than commenting it out.
@jonathanmetzman I'd like to see this running with the corresponding change containerd/containerd#10348 before approving. Thanks! |
OK. Ping me here when youre approval is ready. |
containerd/containerd#10362
The above PR clones the instrumentation repo in oss_fuzz_build.sh