bc-gh: Add Dockerfile and build.sh #12098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I set `disabled` to true because LeakSanitizer claims the fuzzers have leaks. However, this is not true because bc and dc run without leaks under Valgrind. After some debugging, I can cause them to free the memory by putting an `assert(false);` after all of the frees [1] [2], and it trips. But if I remove it, LeakSanitizer sees leaks. Whether it's PEBKAC (probably) or miscompilation (unlikely), I don't know, but I figured I'd commit the necessary stuff for the project. I'll try to figure out the problem later. [1]: https://github.com/gavinhoward/bc/blob/master/src/bc_fuzzer.c#L110 [2]: https://github.com/gavinhoward/bc/blob/master/src/dc_fuzzer.c#L110 Signed-off-by: Gavin D. Howard <gavin@gavinhoward.com>
|
gavinhoward has previously contributed to projects/bc-gh. The previous PR was #12078 |
jonathanmetzman
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I set
disabledto true because LeakSanitizer claims the fuzzers have leaks. However, this is not true because bc and dc run without leaks under Valgrind.After some debugging, I can cause them to free the memory by putting an
assert(false);after all of the frees 1 2, and it trips. But if I remove it, LeakSanitizer sees leaks.Whether it's PEBKAC (probably) or miscompilation (unlikely), I don't know, but I figured I'd commit the necessary stuff for the project.
I'll try to figure out the problem later.