infra: add support for custom LSAN_OPTIONS values #12275
+15
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
correctmost is either the primary contact or is in the CCs list of projects/librsvg. |
correctmost
commented
Jul 26, 2024
| @@ -55,6 +55,7 @@ RUN git clone https://chromium.googlesource.com/chromium/src/tools/code_coverage | |||
| # shouldn't be changed unless a corresponding change is made on | |||
| # ClusterFuzz side as well. | |||
| ENV ASAN_OPTIONS="alloc_dealloc_mismatch=0:allocator_may_return_null=1:allocator_release_to_os_interval_ms=500:check_malloc_usable_size=0:detect_container_overflow=1:detect_odr_violation=0:detect_leaks=1:detect_stack_use_after_return=1:fast_unwind_on_fatal=0:handle_abort=1:handle_segv=1:handle_sigill=1:max_uar_stack_size_log=16:print_scariness=1:quarantine_size_mb=10:strict_memcmp=1:strip_path_prefix=/workspace/:symbolize=1:use_sigaltstack=1:dedup_token_length=3" | |||
| ENV LSAN_OPTIONS="max_leaks=0" | |||
There was a problem hiding this comment.
I assign the default max_leaks value here to ensure that the LSAN_OPTIONS environment variable is defined when run_fuzzer runs.
This seems like the riskiest part of the PR because some scripts and fuzz targets may behave differently when LSAN_OPTIONS is always defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9453
This PR also updates the librsvg project to use an LSan suppressions file now that custom
LSAN_OPTIONSvalues are supported.