[docs] Add instructions on "pull_images" and "check_build" as per suggestion in #1330. #1404
Conversation
|
It's been suggested in #1330 (comment) |
docs/reproducing.md
Outdated
| $ python infra/helper.py pull_images | ||
| ``` | ||
|
|
||
| Docker images get regularly updated. In some cases, a particular issue can be |
There was a problem hiding this comment.
updated with latest version of clang compiler binaries ?
There was a problem hiding this comment.
not necessary clang binaries, I think, e.g. in case of build checks it was our script used in base-runner image. IIUC, we rebuild and update base images once a day, even if nothing has changed for them.
There was a problem hiding this comment.
yes then then add as example
updated with X, Y, etc to give some useful context on why it is done.
There was a problem hiding this comment.
Also pull images can be moved into its own section at start, just to do it for everything, upto you.
docs/reproducing.md
Outdated
| @@ -56,6 +65,14 @@ $ python infra/helper.py reproduce $PROJECT_NAME <fuzz_target_name> <testcase_pa | |||
| ``` | |||
|
|
|||
| This is essentially the previous command that additionally mounts local sources into the running container. | |||
|
|
|||
| - *Reproduce bad build error:* | |||
There was a problem hiding this comment.
Move this to its own big section at end like "# Reproducing OSS-Fuzz issues"
as
"# Reproducing OSS-Fuzz bad build failures".
this is not the right place, this content is for oss-fuzz issues in issue tracker. Also, would need to repeat the pull docker image section.
There was a problem hiding this comment.
Done. Should we move "pull_images" into a separate section as well?
|
:( looks like it got some weird conflicts due to @oliverchang changes, I'll try to clean up |
…gestion in google#1330. (google#1404) * [docs] Add instructions on "pull_images" and "check_build" as per suggestion in google#1330. * Address review feedback * fix a typo
No description provided.