Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[systemd] install wget to download a dictionary for fuzz-json #1683

Merged
merged 1 commit into from
Aug 3, 2018

Conversation

evverx
Copy link
Contributor

@evverx evverx commented Aug 2, 2018

No description provided.

@filbranden
Copy link

Note that when you pull gettext you're getting curl with it, so you might want to consider using it instead of wget, in which case this PR is not really blocking... (Though it might be a good idea to make that dependency on curl explicit if you start using it.)

Cheers,
Filipe

@evverx
Copy link
Contributor Author

evverx commented Aug 2, 2018

I vaguely remember that something happened to me in the past and since then I haven't relied on packages installed implicitly through Recommends :-), so it's indeed a good idea to make dependencies explicit. Regarding wget, it's already used in systemd/systemd#9782 and I'd rather not change it. Plus I believe this PR will be merged before I get to edit oss-fuzz.sh.

@jonathanmetzman jonathanmetzman merged commit d701589 into google:master Aug 3, 2018
@evverx evverx deleted the install-wget branch August 3, 2018 17:50
tmatth pushed a commit to tmatth/oss-fuzz that referenced this pull request Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants