[infra] Update base-builder image to support go-fuzz (#2714). #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dor1s
requested review from
mbarbella-chromium,
inferno-chromium and
jonathanmetzman
|
Travis is unhappy because this updates the base-builder image. |
inferno-chromium
approved these changes
Aug 21, 2019
|
|
||
| # $SHELL is needed for the installer. | ||
| ENV SHELL "bash" | ||
| RUN chmod +x $SRC/installer_linux && \ |
There was a problem hiding this comment.
nit: why not add SHELL="bash" when calling the command itself, this removes lines 34 and 38.
There was a problem hiding this comment.
Hm, didn't know it was possible this way. Thanks!
| ENV SHELL "" | ||
|
|
||
| # Set up Golang environment variables (copied from /root/.bash_profile). | ||
| ENV PATH $PATH:/root/.go/bin |
There was a problem hiding this comment.
nit: this block can be shortened to
ENV GOPATH /root/go
ENV PATH $PATH:/root/.go/bin:$GOPATH/bin
Also, why do we have /root/go and /root/.go ?
There was a problem hiding this comment.
Done. Also added a comment to clarify:
# /root/.go/bin is the standard Go binaries (i.e. go, gofmt, etc).
# $GOPATH/bin is the binaries from the dependencies installed via "go get".
| ENV GOPATH /root/go | ||
| ENV PATH $PATH:$GOPATH/bin | ||
|
|
||
| # Dependency of go-fuzz |
There was a problem hiding this comment.
nit: end with period.
|
Confirmed locally that this doesn't break golang project integration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we agree on this, then we can update golang scripts and also document this.
In the meantime, I'll check locally that this does not break golang project. If it does, I'll just update its scripts in this PR as well.