New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClickHouse fuzzing #3800
ClickHouse fuzzing #3800
Conversation
@@ -0,0 +1,32 @@ | |||
FROM gcr.io/oss-fuzz-base/base-builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this file and build.sh need license headers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will result in a travis failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed.
@@ -4,3 +4,6 @@ primary_contact: "clickhouse-feedback@yandex-team.com" | |||
auto_ccs: | |||
- "security@yandex-team.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll note that using lists for auto_ccs/primary_contact can cause frustration when list members want to access bugs they get emails for but can't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, hope that'll be ok b/c email will be handled by task tracker and visible only to project-specific people.
Actually it looks like the UBSAN build is broken:
The rest of the builds time out (which is fine I will land anyway if the only issue is timeouts). |
Sorry, disabled UBSAN to figure out the problem. |
Merging since all the builds except UBSAN passed in https://travis-ci.org/github/google/oss-fuzz/builds/686733130 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey @kyprizel, TravisCI finished with status TravisBuddy Request Identifier: c4b8a320-9592-11ea-a502-dde60929b9b3 |
Sorry, I think this merged at unlucky time because there was a large clang roll the first time clickhouse was built and now the build is failing: https://oss-fuzz-build-logs.storage.googleapis.com/index.html#clickhouse We may have to revert the integration temporarily if this isn't fixed soon since projects that fail on their first build cause exceptions in ClusterFuzz. |
Let's revert, I'll send one more push later with ubsan fixed. |
Build is failing. This reverts commit 564354a.
Actually, no idea if this was caused by clang roll or if travis would have caught it yesterday but didn't because of a timeout. |
This pull adds Docker and build files for ClickHouse