Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClickHouse fuzzing #3800

Merged
merged 5 commits into from May 14, 2020
Merged

ClickHouse fuzzing #3800

merged 5 commits into from May 14, 2020

Conversation

kyprizel
Copy link
Contributor

This pull adds Docker and build files for ClickHouse

@@ -0,0 +1,32 @@
FROM gcr.io/oss-fuzz-base/base-builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file and build.sh need license headers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will result in a travis failure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

@@ -4,3 +4,6 @@ primary_contact: "clickhouse-feedback@yandex-team.com"
auto_ccs:
- "security@yandex-team.com"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll note that using lists for auto_ccs/primary_contact can cause frustration when list members want to access bugs they get emails for but can't.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, hope that'll be ok b/c email will be handled by task tracker and visible only to project-specific people.

@jonathanmetzman
Copy link
Contributor

Actually it looks like the UBSAN build is broken:

FAILED: cd /src/ClickHouse/build/contrib/arrow-cmake && /src/ClickHouse/build/contrib/flatbuffers/flatc -c -o /src/ClickHouse/build/contrib/arrow-cmake/arrow_gen_headers/arrow/ipc/ /src/ClickHouse/contrib/arrow/format/Message.fbs /src/ClickHouse/contrib/arrow/format/File.fbs /src/ClickHouse/contrib/arrow/format/Schema.fbs /src/ClickHouse/contrib/arrow/format/Tensor.fbs /src/ClickHouse/contrib/arrow/format/SparseTensor.fbs /src/ClickHouse/contrib/arrow/cpp/src/arrow/ipc/feather.fbs
../contrib/flatbuffers/include/flatbuffers/base.h:375:23: runtime error: unsigned integer overflow: 18446744073709551615 + 1 cannot be represented in type 'unsigned long'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../contrib/flatbuffers/include/flatbuffers/base.h:375:23 in 

The rest of the builds time out (which is fine I will land anyway if the only issue is timeouts).

@kyprizel
Copy link
Contributor Author

Sorry, disabled UBSAN to figure out the problem.

@jonathanmetzman
Copy link
Contributor

Merging since all the builds except UBSAN passed in https://travis-ci.org/github/google/oss-fuzz/builds/686733130

Copy link
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanmetzman jonathanmetzman merged commit 564354a into google:master May 14, 2020
@TravisBuddy
Copy link

Hey @kyprizel,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: c4b8a320-9592-11ea-a502-dde60929b9b3

@jonathanmetzman
Copy link
Contributor

Sorry, I think this merged at unlucky time because there was a large clang roll the first time clickhouse was built and now the build is failing: https://oss-fuzz-build-logs.storage.googleapis.com/index.html#clickhouse

We may have to revert the integration temporarily if this isn't fixed soon since projects that fail on their first build cause exceptions in ClusterFuzz.

@kyprizel
Copy link
Contributor Author

kyprizel commented May 15, 2020

Let's revert, I'll send one more push later with ubsan fixed.

jonathanmetzman added a commit that referenced this pull request May 15, 2020
Build is failing.

This reverts commit 564354a.
@jonathanmetzman
Copy link
Contributor

Actually, no idea if this was caused by clang roll or if travis would have caught it yesterday but didn't because of a timeout.

jonathanmetzman added a commit that referenced this pull request May 15, 2020
Build is failing.

This reverts commit 564354a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants