wireshark: move building fuzzers to wireshark repository. #544
Conversation
|
It seems we have some license problems - Apache License 2.0 is currently not allowed in wireshark repository. |
|
build.sh will live in your repo, it can have any license you like to have there. once it lands there, let us know and we can merge this CL. |
(oss-fuzz part google/oss-fuzz#544) Change-Id: I54cf7a7b1aaa49582b5fff8bd034187aa6a9bdec Reviewed-on: https://code.wireshark.org/review/21302 Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl>
|
Patch merged upstream, build.sh relicenced to GPLv2. This can be merged as well. |
| for dissector in $FUZZ_MEDIA_TYPE_DISSECTORS; do | ||
| generate_fuzzer "media_type-${dissector}" "-DFUZZ_DISSECTOR_TABLE=\"media_type\" -DFUZZ_DISSECTOR_TARGET=\"$dissector\"" | ||
| done | ||
| $SRC/wireshark/tools/oss-fuzzshark/build.sh all |
There was a problem hiding this comment.
This is fine as is, but I would encourage you to make one more step
and make the fuzz targets build as part of make so that they are always built and tested.
You don't have to link them against libFuzzer or other fizzing engines -- instead you may link them against something like https://github.com/llvm-mirror/llvm/tree/master/lib/Fuzzer/standalone
Then you'll be able to use those build targets for reproducing oss-fuzz bug reports and for regression testing,
w/o having to call this .sh script.
More: https://github.com/google/oss-fuzz/blob/master/docs/ideal_integration.md
There was a problem hiding this comment.
Change to integrate fuzzer to wireshark build system is pending completion and review: https://code.wireshark.org/review/21064/. Original fuzzer is more interactive - it can list all targets, and is using environment variables to select target (instead of prepreocessor defines in oss version).
I am aware that current situation is not perfect, like build fails (https://oss-fuzz-build-logs.storage.googleapis.com/log-472514ce-1a41-4f14-8798-d45084212a65.txt) [fixed upstream], still bigger changes in build system -> more users are affected, it need to be discussed, and changes in tools/oss-fuzzshark/ can be merged fast.
as advised in #533 (comment) moving fuzzer build logic to wireshark repository.