Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fuzzing sigstore #6890

Merged
merged 4 commits into from
Nov 29, 2021
Merged

Fuzzing sigstore #6890

merged 4 commits into from
Nov 29, 2021

Conversation

naveensrinivasan
Copy link
Contributor

Included sigstore/sigstore project

@naveensrinivasan
Copy link
Contributor Author

@oliverchang FYI...

oliverchang
oliverchang approved these changes Nov 24, 2021
View reviewed changes
Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

projects/sigstore/build.sh Outdated Show resolved Hide resolved
projects/sigstore/project.yaml Outdated Show resolved Hide resolved
@naveensrinivasan
Fuzzing sigstore
2d73fd9 
Included sigstore/sigstore project

Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com>
@oliverchang oliverchang changed the base branch from master to DavidKorczynski-patch-1 November 29, 2021 01:37
@oliverchang oliverchang changed the base branch from DavidKorczynski-patch-1 to master November 29, 2021 01:37
@oliverchang oliverchang merged commit 854befe into google:master Nov 29, 2021
@jonathanmetzman
Copy link
Contributor

If we're fuzzing sigstore in OSS-Fuzz, then I think the PR adding ClusterFuzzLite to sigstore is wrong.
OSS-Fuzz users don't need to do another integration for ClusterFuzzLite. They should use CIFuzz (which has the same functionality) instead.

@naveensrinivasan
Copy link
Contributor Author

If we're fuzzing sigstore in OSS-Fuzz, then I think the PR adding ClusterFuzzLite to sigstore is wrong.
OSS-Fuzz users don't need to do another integration for ClusterFuzzLite. They should use CIFuzz (which has the same functionality) instead.

OK, that Makes sense. I will remove the PR in sigstore to use the clusterfuzzlite. Thanks

@naveensrinivasan naveensrinivasan deleted the naveen/feat/sigstore branch November 29, 2021 16:36
@naveensrinivasan naveensrinivasan mentioned this pull request Nov 29, 2021
Closed
@jonathanmetzman
Copy link
Contributor

If we're fuzzing sigstore in OSS-Fuzz, then I think the PR adding ClusterFuzzLite to sigstore is wrong.
OSS-Fuzz users don't need to do another integration for ClusterFuzzLite. They should use CIFuzz (which has the same functionality) instead.

OK, that Makes sense. I will remove the PR in sigstore to use the clusterfuzzlite. Thanks

Yes. You can just use the instructions here to set up CIFuzz: https://google.github.io/oss-fuzz/getting-started/continuous-integration/

@naveensrinivasan
Copy link
Contributor Author

How do we coverage for oss-fuzz?

Also for CIFuzz if there is crash will everyone be able to see the crash call-stack and the data that caused it to happen?

@naveensrinivasan naveensrinivasan mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidKorczynski DavidKorczynski DavidKorczynski left review comments

@oliverchang oliverchang oliverchang approved these changes

@lukehinds lukehinds lukehinds left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@naveensrinivasan @jonathanmetzman @DavidKorczynski @oliverchang @lukehinds