Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fuzztest integration #8784

Merged
merged 21 commits into from Nov 14, 2022
Merged

fuzztest integration #8784

merged 21 commits into from Nov 14, 2022

Conversation

DavidKorczynski
Copy link
Collaborator

@DavidKorczynski DavidKorczynski commented Oct 15, 2022 •
edited

Signed-off-by: David Korczynski david@adalogics.com

Cross referencing google/fuzztest#69

@DavidKorczynski
fuzztest integration
8326402 
Signed-off-by: David Korczynski <david@adalogics.com>
@DavidKorczynski DavidKorczynski mentioned this pull request Oct 15, 2022
Closed
@DavidKorczynski DavidKorczynski marked this pull request as draft October 15, 2022 16:36
@DavidKorczynski
Copy link
Collaborator Author

this works with libfuzzer, centipede, ubsan, asan and coverage

Screenshot from 2022-10-14 01-18-29

@DavidKorczynski DavidKorczynski mentioned this pull request Oct 15, 2022
Open
jonathanmetzman
jonathanmetzman reviewed Oct 20, 2022
View reviewed changes
infra/base-images/base-builder/Dockerfile Outdated Show resolved Hide resolved
infra/base-images/base-builder/compile_gfuzztests.sh Outdated Show resolved Hide resolved
projects/fuzztest-example/build.sh Outdated Show resolved Hide resolved
@DavidKorczynski
fuzztest-raksha: initial integration
633d5d1 
Signed-off-by: David Korczynski <david@adalogics.com>
lszekeres
lszekeres reviewed Oct 24, 2022
View reviewed changes
infra/base-images/base-builder/Dockerfile Outdated Show resolved Hide resolved
infra/base-images/base-builder/compile_gfuzztests.sh Outdated Show resolved Hide resolved
infra/base-images/base-builder/compile_gfuzztests.sh Outdated Show resolved Hide resolved
projects/fuzztest-example/setup_configs.sh Outdated Show resolved Hide resolved
projects/fuzztest-raksha/setup_configs.sh Outdated Show resolved Hide resolved
infra/base-images/base-builder/compile_gfuzztests.sh Outdated Show resolved Hide resolved
infra/base-images/base-builder/compile_gfuzztests.sh Outdated Show resolved Hide resolved
infra/base-images/base-runner/coverage Show resolved Hide resolved
@DavidKorczynski
refine comments
ab5f5cc 
Signed-off-by: David Korczynski <david@adalogics.com>
@DavidKorczynski
nit
210e98c 
Signed-off-by: David Korczynski <david@adalogics.com>
@DavidKorczynski
rename gfuzztest to fuzztest
8557a41 
Signed-off-by: David Korczynski <david@adalogics.com>
@DavidKorczynski
Simplify raksha
7729031 
Signed-off-by: David Korczynski <david@adalogics.com>
@DavidKorczynski
remove unused file
223f075
@DavidKorczynski
use diff instead of files
c82f4c5
@DavidKorczynski
cleanup fuzztest-example
e00ae71
@DavidKorczynski
Update fuzztest tag name
ca9ac8f 
Signed-off-by: David Korczynski <david@adalogics.com>
@DavidKorczynski
fix individual reports for fuzztests
b041413 
Signed-off-by: David Korczynski <david@adalogics.com>
@DavidKorczynski DavidKorczynski mentioned this pull request Oct 27, 2022
Merged
@DavidKorczynski DavidKorczynski marked this pull request as ready for review October 27, 2022 21:58
oliverchang
oliverchang reviewed Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this PR! We just need to fix bad_build_check to check the main/base binary and we should be good to go here!

@DavidKorczynski
Copy link
Collaborator Author

bad build check should be fixed now. Which revealed an issue in the UBSAN steps, which is fixed in google/fuzztest#73

So once google/fuzztest#73 is merged then we can rerun tests here.

@DavidKorczynski DavidKorczynski mentioned this pull request Nov 9, 2022
Merged
@oliverchang
Copy link
Collaborator

/gcbrun trial_build.py all --sanitizer address --fuzzing-engine libfuzzer

@oliverchang
Copy link
Collaborator

Thanks! @Navidem can you help merge this tomorrow if trial build passes?

@DavidKorczynski
Copy link
Collaborator Author

I see the trial build failed: is it possible to get some debug info? One of the potential pitfalls I can think of is it that some projects may have fuzzers with @ in the name as well -- these will break. If this is what's causing the trial build to fail we could make the fuzztest fuzzer check more constrained.

@jonathanmetzman
Copy link
Contributor

jonathanmetzman commented Nov 10, 2022 •
edited

failures:
wasmtime - spurious
spdlog - spurious
ots -spurious
libpsl - spurious
jwt-verify-lib-fuzzing - spurious
gstreamer - spurious (zlib seemed to have connection issue)
clamav - spurious
bluez - spurious.

think all of these were zlib issues except for wasmtime which is now failing in prod

jonathanmetzman
jonathanmetzman approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

projects/fuzztest-example/Dockerfile Outdated Show resolved Hide resolved
projects/fuzztest-example/Dockerfile Outdated Show resolved Hide resolved
projects/fuzztest-raksha/Dockerfile Outdated Show resolved Hide resolved
@DavidKorczynski
fix nits
6c2fa00 
Signed-off-by: David Korczynski <david@adalogics.com>
@oliverchang oliverchang merged commit 9452275 into master Nov 14, 2022
@oliverchang oliverchang deleted the fuzztest-initial-int branch November 14, 2022 02:34
@Navidem Navidem mentioned this pull request Nov 23, 2022
Closed
@Navidem Navidem removed their assignment Dec 9, 2022
@silvergasp silvergasp mentioned this pull request Oct 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lszekeres lszekeres lszekeres left review comments

@oliverchang oliverchang oliverchang approved these changes

@jonathanmetzman jonathanmetzman jonathanmetzman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@DavidKorczynski @oliverchang @jonathanmetzman @lszekeres @Navidem