[infra] delete directories with FI reports with rmtree #9265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those directories aren't empty usually so `rmdir` fails with
```
INFO:fuzz_introspector.json_report:Finish handling sections that need json output
INFO:__main__:Ending fuzz introspector report generation
INFO:__main__:Ending fuzz introspector post-processing
Traceback (most recent call last):
File "/home/vagrant/oss-fuzz-2/./infra/helper.py", line 1513, in <module>
sys.exit(main())
File "/home/vagrant/oss-fuzz-2/./infra/helper.py", line 192, in main
result = introspector(args)
File "/home/vagrant/oss-fuzz-2/./infra/helper.py", line 1243, in introspector
os.rmdir(introspector_dst)
OSError: [Errno 39] Directory not empty: '/home/vagrant/oss-fuzz-2/build/out/dbus-broker/introspector-report'
```
It should make it possible to run `introspector` a few times in a row
when for example fuzz targets are changed locally between subsequent
runs.
It's a follow-up to google#9243.
|
Thanks! |
eamonnmcmanus
pushed a commit
to eamonnmcmanus/oss-fuzz
that referenced
this pull request
Mar 15, 2023
Those directories aren't empty usually so `rmdir` fails with
```
INFO:fuzz_introspector.json_report:Finish handling sections that need json output
INFO:__main__:Ending fuzz introspector report generation
INFO:__main__:Ending fuzz introspector post-processing
Traceback (most recent call last):
File "/home/vagrant/oss-fuzz-2/./infra/helper.py", line 1513, in <module>
sys.exit(main())
File "/home/vagrant/oss-fuzz-2/./infra/helper.py", line 192, in main
result = introspector(args)
File "/home/vagrant/oss-fuzz-2/./infra/helper.py", line 1243, in introspector
os.rmdir(introspector_dst)
OSError: [Errno 39] Directory not empty: '/home/vagrant/oss-fuzz-2/build/out/dbus-broker/introspector-report'
```
It should make it possible to run `introspector` a few times in a row
when for example fuzz targets are changed locally between subsequent
runs.
It's a follow-up to google#9243.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those directories aren't empty usually so
rmdirfails withIt should make it possible to run
introspectora few times in a row when for example fuzz targets are changed locally between subsequent runs.It's a follow-up to #9243.