Clean Shell Scripts #999
Merged
Clean Shell Scripts #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Double quote array expansions, otherwise they're like $* and break on spaces.
In POSIX sh, 'pushd' is not supported. In POSIX sh, 'popd' is not supported.
Iterating over ls output is fragile. Use globs.
Add shebang
tmatth
pushed a commit
to tmatth/oss-fuzz
that referenced
this pull request
Oct 22, 2018
* Clean all.sh Double quote array expansions, otherwise they're like $* and break on spaces. * Clean dropbear/build.sh In POSIX sh, 'pushd' is not supported. In POSIX sh, 'popd' is not supported. * Clean woff2/build.sh Iterating over ls output is fragile. Use globs. * Clean tinyxml2/build.sh Add shebang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double quote array expansions, otherwise they're like
$*and break on spaces.In POSIX sh,
pushdis not supported.In POSIX sh,
popdis not supported.Iterating over
lsoutput is fragile. Use globs.Add shebang