Do not record Maven compile scope in dependency groups
#1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1003 +/- ##
==========================================
- Coverage 64.97% 64.96% -0.02%
==========================================
Files 149 149
Lines 12257 12259 +2
==========================================
Hits 7964 7964
- Misses 3842 3844 +2
Partials 451 451 ☔ View full report in Codecov by Sentry. |
another-rex
approved these changes
May 30, 2024
josieang
pushed a commit
to josieang/osv-scanner
that referenced
this pull request
Jun 6, 2024
We should only record non-default dependency groups. For Maven, `compile` is the default scope so it should not be recorded. https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#dependency-scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should only record non-default dependency groups.
For Maven,
compileis the default scope so it should not be recorded.https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#dependency-scope