Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't try to upload code coverage on macOS #1020

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Jun 4, 2024

This keeps failing on macOS, so let's skip it for now

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.04%. Comparing base (f2a30a8) to head (e8d4ea7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1020   +/-   ##
=======================================
  Coverage   65.04%   65.04%           
=======================================
  Files         149      149           
  Lines       12252    12252           
=======================================
  Hits         7969     7969           
  Misses       3835     3835           
  Partials      448      448           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@another-rex another-rex merged commit 8afe157 into google:main Jun 4, 2024
13 checks passed
@G-Rath G-Rath deleted the ci/dont-upload-coverage-for-macos branch June 4, 2024 23:51
@G-Rath
Copy link
Collaborator Author

G-Rath commented Jun 4, 2024

fwiw CodeCov have said they hope to have a fix live by end of week 😅

josieang pushed a commit to josieang/osv-scanner that referenced this pull request Jun 6, 2024
This keeps failing on macOS, so let's skip it for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants