Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken TUI styling #1023

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Fix broken TUI styling #1023

merged 1 commit into from
Jun 5, 2024

Conversation

michaelkedar
Copy link
Member

lipgloss v0.11.0 made it so that all the Style methods no longer mutate the style, which I was relying on.

@michaelkedar michaelkedar added the guided remediation Related to guided remediation / osv-scanner fix label Jun 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 65.15%. Comparing base (b1b8bfa) to head (dada9e1).
Report is 5 commits behind head on main.

Files Patch % Lines
cmd/osv-scanner/fix/model.go 0.00% 6 Missing ⚠️
internal/tui/in-place-info.go 0.00% 2 Missing ⚠️
internal/tui/vuln-list.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1023   +/-   ##
=======================================
  Coverage   65.15%   65.15%           
=======================================
  Files         149      149           
  Lines       12338    12338           
=======================================
  Hits         8039     8039           
  Misses       3848     3848           
  Partials      451      451           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelkedar michaelkedar merged commit 4e5c43a into google:main Jun 5, 2024
13 checks passed
@michaelkedar michaelkedar deleted the tui-fix branch June 5, 2024 03:26
josieang pushed a commit to josieang/osv-scanner that referenced this pull request Jun 6, 2024
lipgloss v0.11.0 made it so that all the `Style` methods no longer
mutate the style, which I was relying on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guided remediation Related to guided remediation / osv-scanner fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants