Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nil check to cyclonedx enumeration #320

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Add nil check to cyclonedx enumeration #320

merged 3 commits into from
Mar 30, 2023

Conversation

michaelkedar
Copy link
Member

Fix #319

oliverchang
oliverchang approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could we please add a simple test for this?

oliverchang
oliverchang approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

internal/sbom/cyclonedx_test.go Outdated Show resolved Hide resolved
internal/sbom/cyclonedx_test.go Outdated Show resolved Hide resolved
@michaelkedar michaelkedar merged commit 3812a9b into google:main Mar 30, 2023
@oliverchang
Copy link
Collaborator

@another-rex might be worth getting a point release out for this, given that it's a pretty minor fix and our users are running into this?

@another-rex
Copy link
Collaborator

Can do, I'll make a 1.3.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverchang oliverchang oliverchang approved these changes

@another-rex another-rex another-rex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

segmentation fault when scanning a CycloneDX bom.json without dependencies
3 participants
@michaelkedar @oliverchang @another-rex