Optimize Dockerfile and add .dockerignore #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
another-rex
reviewed
Jul 14, 2023
There was a problem hiding this comment.
Thanks! The dockerfile updates look good, though I don't think the .dockerignore is necessary, as it might hinder us wanting to run tests in docker in the future, while not significantly speeding up the build process (there's not that many files being ignored).
Can you remove the .dockerignore?
Removed the |
|
@another-rex - can we merge this? |
another-rex
reviewed
Jul 26, 2023
|
Sorry for the delay, Just been testing Github actions recently and the relative ENTRYPOINT might cause problems, as github actions changes the working directory, and I haven't had time to test it out properly yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include:
Removed the
mkdircommand as theWORKDIRinstruction automatically creates the folder if it doesn't already exist.Added a .dockerignore file to prevent unnecessary files (such as README, tests, Dockerfile itself, etc.) from being included in the Docker context, thereby speeding up the build process.
Combined two
RUNinstructions into one in order to reduce the number of layers in the final image.