-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow users to override GOVERSION #850
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #850 +/- ##
==========================================
+ Coverage 59.78% 60.96% +1.17%
==========================================
Files 136 144 +8
Lines 11268 11762 +494
==========================================
+ Hits 6737 7171 +434
- Misses 4102 4119 +17
- Partials 429 472 +43 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you also add a snapshot test for this? (just a folder under cmd/osv-scanner/fixtures filled with a go.mod file and a osv-scanner config file should be enough)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
fixes #848.
Allow users to specify a
GOVERSION
other than the one ingo.mod
.Usage: in toml,
GoVersionOverride = "1.21.0"