GR: Add test universe generation script and tests for patch generation #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #967 +/- ##
==========================================
+ Coverage 63.71% 63.99% +0.28%
==========================================
Files 146 146
Lines 11958 11958
==========================================
+ Hits 7619 7653 +34
+ Misses 3875 3853 -22
+ Partials 464 452 -12 ☔ View full report in Codecov by Sentry. |
michaelkedar
added
the
guided remediation
cuixq
approved these changes
May 8, 2024
| return clienttest.ResolutionUniverse{}, err | ||
| } | ||
| for _, r := range reqs { | ||
| // don't bother writing dev dependencies |
There was a problem hiding this comment.
How about optional dependencies?
There was a problem hiding this comment.
npm tries to install optional dependencies if possible, so I'd like to keep them in the universe
josieang
pushed a commit
to josieang/osv-scanner
that referenced
this pull request
Jun 6, 2024
google#967) Made a go script that creates a universe file for the `MockResolutionClient` (google#909) from the current real deps.dev & OSV data used during in-place / relock / relax computation. This has let me add some real-world in-place & relax patch generation test cases to test for regression without it breaking constantly due to new versions. I've only added one universe because the files are pretty large. The in-place/relax patch generation tests are basically end-to-end tests - it's not really written in a way that makes testing only the patch computation functionality possible. (This might be a code smell, but I don't think it's practical to structure the code in such a way).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a go script that creates a universe file for the
MockResolutionClient(#909) from the current real deps.dev & OSV data used during in-place / relock / relax computation.This has let me add some real-world in-place & relax patch generation test cases to test for regression without it breaking constantly due to new versions. I've only added one universe because the files are pretty large.
The in-place/relax patch generation tests are basically end-to-end tests - it's not really written in a way that makes testing only the patch computation functionality possible. (This might be a code smell, but I don't think it's practical to structure the code in such a way).