Update snapshots #986
Update snapshots #986
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #986 +/- ##
=======================================
Coverage 64.05% 64.06%
=======================================
Files 146 146
Lines 11977 11977
=======================================
+ Hits 7672 7673 +1
+ Misses 3853 3852 -1
Partials 452 452 ☔ View full report in Codecov by Sentry. |
| @@ -176,7 +176,7 @@ func TestRun(t *testing.T) { | |||
| { | |||
| name: "Scan locks-many", | |||
| args: []string{"", "./fixtures/locks-many"}, | |||
| exit: 0, | |||
| exit: 1, | |||
There was a problem hiding this comment.
@another-rex we may need to update the fixtures to make sure no vulnerabilities. will you be happy to help on this?
| @@ -576,12 +576,12 @@ func TestRun_Licenses(t *testing.T) { | |||
| { | |||
| name: "No vulnerabilities with license summary", | |||
| args: []string{"", "--experimental-licenses-summary", "./fixtures/locks-many"}, | |||
| exit: 0, | |||
| exit: 1, | |||
There was a problem hiding this comment.
Should we just bump the version in the relevant lock files in this dir instead? otherwise we're no longer testing the same thing.
There was a problem hiding this comment.
busybox version 1.35.0-r29 has a vulnerability in the test snapshot which I am not sure if we want to keep this version for some testing purpose.
also bumping the version alpine.cdx.xml includes changing cpe, purl and properties, so I mentioned @another-rex to see if he could help with preparing the new fixture.
|
this is addressed in #990 |
Currently tests are broken due to a new vulnerability in test fixtures. This PR aims to fix these failures by updating the snapshots