Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website latency reduction #1013

Open
andrewpollock opened this issue Feb 9, 2023 · 3 comments
Open

Website latency reduction #1013

andrewpollock opened this issue Feb 9, 2023 · 3 comments
Labels
frontend Frontend Infrastructure ui UI bugs/FRs

Comments

@andrewpollock
Copy link
Contributor

I'll use this issue to collect some of the opportunities to improve page load time based on my attempts to measure latency for defining an SLO:
@andrewpollock andrewpollock added ui UI bugs/FRs frontend Frontend Infrastructure labels Feb 9, 2023
@zahraaalizadeh
Copy link
Collaborator

I'm planning to work on this one.

@zahraaalizadeh zahraaalizadeh mentioned this issue May 1, 2024
Closed
@zahraaalizadeh
Copy link
Collaborator

I just assessed the performance using Page Speed Insight:
https://pagespeed.web.dev/analysis/https-osv-dev/rsqqsi0hrn?form_factor=mobile

and it indicates potential room for improvement on the mobile version.

@zahraaalizadeh zahraaalizadeh self-assigned this May 8, 2024
@zahraaalizadeh
Copy link
Collaborator

zahraaalizadeh commented Jun 18, 2024 •
edited
Loading

One related PR: #2221

This was referenced Jun 26, 2024
Merged
Merged
another-rex pushed a commit that referenced this issue Jun 27, 2024
@zahraaalizadeh
Fix layout shift in list page (#2349)
da56031 
issue: #1013

This change:
- declares the height of search box to avoid layout shift
- declares the size of published sorted arrow icon
- declares the height of text fields above the turbo frame

Before:
<img width="791" alt="Screenshot 2024-06-26 at 1 23 55 PM"
src="https://github.com/google/osv.dev/assets/73332835/46f8fa63-852b-4868-a39e-7ba73e58c6be">

After:
<img width="659" alt="Screenshot 2024-06-26 at 5 15 40 PM"
src="https://github.com/google/osv.dev/assets/73332835/fcb7ff1f-937d-4036-9b6c-ad3d471377c3">
another-rex pushed a commit that referenced this issue Jun 28, 2024
@zahraaalizadeh
Remove relative-time lib to improve CLS (#2350)
25bc7c6 
issue: #1013

Currently, we use relative-time package to convert timestamp to a human
readable relative time, when
displaying published time of the bug in the list page.

Using this approach is not optimised as it changes the texts in the
loading time and leads to CLS issues.

This change replaces relative-time lib in favour of a new template tag
which converts the published to a human readable relative time using a
utility function.

Before:
<img width="684" alt="Screenshot 2024-06-26 at 5 33 14 PM"
src="https://github.com/google/osv.dev/assets/73332835/e6c32745-ae07-4494-b172-f68107ae06c8">


After:
<img width="766" alt="Screenshot 2024-06-26 at 6 29 22 PM"
src="https://github.com/google/osv.dev/assets/73332835/904016be-da9c-49da-af05-15ee4d911954">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend Frontend Infrastructure ui UI bugs/FRs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewpollock @zahraaalizadeh