Deduplicate affected versions #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we don't wind up with duplicated commits when we map versions to commits. This does highlight some potential simplistic treatment of CVEs with multiple CPEs.
It has a good example encountered in the wild where duplicate versions and therefore commits were extracted
oliverchang
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some preliminary test coverage to
ExtractVersionInfoand avoids adding duplicates toAffectedVersion, preventing duplicate commit hashes getting added further downstream when they are mapped.This highlights the potential need to look more holistically at the nodes when extracting versions, because each one could be for a completely different CPE...