Hackage and GHC version enumeration (#1418)

[frasertweedale]

Add version enumeration for the Haskell ecosystems: Hackage (the main package index) and GHC (the toolchain).

Fixes: #1418

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[michaelkedar]

Thanks for doing this!

Looks mostly good to me, just a few small things

[michaelkedar]

LGTM, just one typo

[michaelkedar]

/gcbrun

[michaelkedar]

I got this error when running the tests

ERROR: test_next_version (osv.ecosystems.haskell_test.GHCEcosystemTest.test_next_version)
Test next_version.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/workspace/osv/ecosystems/haskell_test.py", line 41, in test_next_version
    self.assertEqual('0.29', ecosystem.next_version('GHC', '0'))
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspace/osv/ecosystems/helper_base.py", line 46, in next_version
    versions = self.enumerate_versions(package, version, fixed=None)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspace/osv/ecosystems/haskell.py", line 143, in enumerate_versions
    self.sort_versions(versions)
  File "/workspace/osv/ecosystems/helper_base.py", line 65, in sort_versions
    versions.sort(key=self.sort_key)
  File "/workspace/osv/ecosystems/haskell.py", line 96, in sort_key
    return semver_index.parse(version)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspace/osv/semver_index.py", line 104, in parse
    return semver.Version.parse(coerce(version))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builder/home/.local/share/virtualenvs/workspace-dqq3IVyd/lib/python3.11/site-packages/semver/version.py", line 646, in parse
    raise ValueError(f"{version} is not valid SemVer string")
ValueError: 7.10.3a is not valid SemVer string

----------------------------------------------------------------------

[frasertweedale]

Thanks, looking into it.

[frasertweedale]

There was one tag with an unexpected format that snuck through the checks and caused this failure. I made the tag processing more strict.

[michaelkedar]

/gcbrun

[michaelkedar]

This all LGTM. Thanks again for working on this!

I'm going to merge this now and trigger a reimport on our staging instance. We should start to see the affected versions being populated.

If everything's working, this will go into production when we do a release next week.

[frasertweedale]

Thanks for your reviews!