Update last modified time of combine-to-osv entries #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
another-rex
approved these changes
May 6, 2024
another-rex
pushed a commit
that referenced
this pull request
May 7, 2024
hogo6002
added a commit
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2103
The current
modfiedtime of a combine-to-osv entry only reflects the CVE modified time without checking if anypartshas been changed. Updates code to set themodifiedfield to the most recent modification time of parts' components or the original CVE entry.os.Stat(file).ModTime()to check the last modified time of each part.PackageInfo'smodifiedfield if the part modified time is later than the original CVE's modified time.It may not be the best implementation, but its failure wouldn't affect the logic of any existing code.