Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix layout shift in list page #2349

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Fix layout shift in list page #2349

merged 3 commits into from
Jun 27, 2024

Commits on Jun 26, 2024

  1. Declare the height of search box to avoid layout shift

    @zahraaalizadeh
    zahraaalizadeh committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    021a987 View commit details
    Browse the repository at this point in the history

  2. Declare the size of published sorted arrow 

    to avoid layout shift. The reason of the shift
is the width and height of the icon was set to
auto, so when the icon is not loaded yet it displays
"arrow-upward" text which take way more space
comparing to a 18px icon.
    @zahraaalizadeh
    zahraaalizadeh committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    48130b2 View commit details
    Browse the repository at this point in the history

  3. Declare the height of text fields before turbo frame 

    This change prevents the vertical layout shift of
turbo frame after the web fonts were loaded.
    @zahraaalizadeh
    zahraaalizadeh committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c0d8d57 View commit details
    Browse the repository at this point in the history