Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpine version enumeration #769

Merged
merged 16 commits into from
Oct 13, 2022
Merged

Conversation

another-rex
Copy link
Contributor

  • Enumerate alpine versions.
  • Some refactoring of ecosystems.py to better follow python conventions
  • Some minor improvements to typing
  • Add in univers library for alpine version comparison.

osv/ecosystems.py Outdated Show resolved Hide resolved
osv/ecosystems.py Outdated Show resolved Hide resolved
osv/ecosystems_test.py Outdated Show resolved Hide resolved
osv/ecosystems_test.py Outdated Show resolved Hide resolved
osv/ecosystems_test.py Show resolved Hide resolved
osv/ecosystems.py Outdated Show resolved Hide resolved
Copy link
Contributor

@andrewpollock andrewpollock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I need more time to review the changes to ecosystems.py as they're larger and more complex

@another-rex another-rex enabled auto-merge (squash) October 13, 2022 02:58
@another-rex another-rex merged commit 6e2c427 into google:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants