packetdrill: fix compilation/runtime error for linux 3.x #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For linux 3.10, TCP_CC_INFO and SO_MEMINFO are not supported. When we define HAVE_SO_MEMINFO / HAVE_TCP_CC_INFO as 0, functions like write_tcp_bbr_cc_info and write_so_meminfo will not be accessed. So wrap them with #ifdef and #endif. Also, for lower linux version, tcp_info option value has less fields(e.g. 120 bytes). So remove the size assert. This commit is based on the following packetdrill upstream pull request, with a slightly tweaked commit description: google#13 Signed-off-by: Neal Cardwell <ncardwell@google.com> Change-Id: I2f4f8cea7357356f2041eabed044b6f7616d4e91
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
dcaratti
added a commit
to dcaratti/packetdrill
that referenced
this pull request
Jan 27, 2021
mptcp: ADD_ADDR are now sent sooner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For linux 3.10, TCP_CC_INFO and SO_MEMINFO are not supported. When we
define HAVE_SO_MEMINFO / HAVE_TCP_CC_INFO as 0, functions like
write_tcp_bbr_cc_info and write_so_meminfo will not be accessed. So
wrap them with #ifdef and #endif.
Also, for lower linux version, tcp_info option value has less
fields(e.g. 120 bytes). So remove the size assert.
This commit is based on the following packetdrill upstream pull
request, with a slightly tweaked commit description:
#13
Signed-off-by: Neal Cardwell ncardwell@google.com
Change-Id: I2f4f8cea7357356f2041eabed044b6f7616d4e91