Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a link instead of inline photo for photos served by other domains in zero-rating mode #218

Closed
gimite opened this issue Nov 18, 2015 · 1 comment
Closed

Show a link instead of inline photo for photos served by other domains in zero-rating mode #218

gimite opened this issue Nov 18, 2015 · 1 comment
Labels
feature request
Milestone
p2

Comments

@gimite
Copy link
Contributor

gimite commented Nov 18, 2015

Currently, even in zero-rating mode, person record photos can be served by external domains if the user specified URL of the photo instead of uploading one.

We should probably proxy such photos via our domain in zero-rating mode. Alternative is to just show a link to the photo saying that payment may be required.
@gimite gimite added this to the p2 milestone Nov 18, 2015
@gimite gimite mentioned this issue Nov 18, 2015
Merged
@gimite
Copy link
Contributor Author

gimite commented Dec 2, 2015

Let's proceed with an implementation to show a link to the photo saying that payment may be required for now.

@gimite gimite mentioned this issue Jan 14, 2016
Open
@gimite gimite changed the title Proxy photos served by other domains via Person Finder domain in zero-rating mode Show a link instead of inline photo for photos served by other domains in zero-rating mode Jan 14, 2016
gimite added a commit that referenced this issue Jan 14, 2016
@gimite
Show a link instead of inline photo for photos served by other domain…
edac47d 
…s in zero-rating mode. #218
gimite added a commit that referenced this issue Jan 15, 2016
@gimite
Merge pull request #240 from google/gimite-zero-rating-picture
51301af 
Show a link instead of inline photo for photos served by other domains in zero-rating mode. #218
@gimite gimite closed this as completed Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
p2
Development

No branches or pull requests
1 participant
@gimite