Contains fix for bug #79 #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix! I will take a look. |
|
The change looks good to me. Before pulling your change, can you sign this agreement: The CLA is necessary mainly because you own the |
|
Thanks for accepting my pull request. As directed, I had signed the CLA under individual category & tagged my github account (kspviswa) to it. Please let me know, if anything else is pending from my side. BR, |
|
Cherry-picked c70b55e . Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is quite a bug :) . The home country span element was missing the create.html.template file. I just added the same (copying from view.html.template). Also used the "trans" element to support language compatibility.
Unit tested & found OK. Attached screen shots.
Home country field now visible
Viewing the added record with the added Home country