Make ToS page a proxy to the actual ToS page, to make it zero-rating mode friendly. #7 #220
Conversation
|
|
||
| {# In case we fail to fetch/parse the ToS page (e.g., the page has #} | ||
| {# changed its layout), we fall back to show a link to the page instead. #} | ||
| <p><a href="{{tos_url}}">Click here to see the terms of service (external site)</a></p> |
There was a problem hiding this comment.
And also add auto redirect?
There was a problem hiding this comment.
It may require payment, so I think it's better not to redirect automatically. What do you think?
There was a problem hiding this comment.
I see. That makes sense.
BTW should we l10n this page? Also, "external site" is probably not good enough for most users. maybe add a more friendly message e.g. "clicking on the link may incur additional cost from your mobile carrier as it takes you to an external site." Or, do you think it's not necessary since this is only for the supposedly-minor error case?
There was a problem hiding this comment.
I'm not really sure. Let's discuss both i18n and wording in the next meeting with @nmakida .
I understand your point, but I feel saying "additional cost" may be also confusing, because it gives impression that we require special cost compared to other normal sites. Truth is that the same data fee as other sites are applied, but it's not free as google.org.
Also, I also embed " (external site)" text to every external links at app/tos.py:56. Here we cannot embed too long text.
There was a problem hiding this comment.
Based on the conversation, I think the current state is good as is, at least for now. I'm going to LGTM.
|
LGTM. Wording etc, we may still want to follow up with nmakida@, though. |
|
Thanks, then I will merge it for now. I'll make a follow-up wording changes when needed. |
Make ToS page a proxy to the actual ToS page, to make it zero-rating mode friendly. #7
No description provided.