Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS changes suggested by Rupert Breheny. A lot of minor tweaks. As for major changes, on mobile (or any sufficiently small screen), the two columns in the create page become one 100% width column. #51

Merged
merged 3 commits into from
May 16, 2015

Conversation

Jessie-Newman
Copy link
Contributor

No description provided.

…r major changes, on mobile (or any sufficiently small screen), the two columns in the create page become one 100% width column.
@gimite
Copy link
Contributor

gimite commented May 15, 2015

LGTM. Great, it immediately became mobile friendly! I don't have time to push this before my flight. Ping kpy@ who can pull your change and make a push. PF playbook is updated to support github.

@gimite
Copy link
Contributor

gimite commented May 15, 2015

Also verified with android chrome and android uc browser.

@skywhale
Copy link
Contributor

I can manually merge and push the changes in about 5 hours. Let me know if there are other changesets that I should also push together.

@zestyping
Copy link
Contributor

This has been merged and pushed to production. I'm not sure why GitHub hasn't detected the merge and closed this request automatically.

@gimite gimite merged commit 019ae10 into master May 16, 2015
@gimite
Copy link
Contributor

gimite commented May 16, 2015

@zestyping I believe you pushed this branch directly but didn't merge this branch to master. I have just done it. Anyway thanks for the push!

@gimite gimite deleted the jessien-mobile-single-column branch May 16, 2015 09:33
@zestyping
Copy link
Contributor

Thanks!

On Sat, May 16, 2015 at 2:33 AM, Hiroshi Ichikawa notifications@github.com
wrote:

@zestyping https://github.com/zestyping I believe you pushed this
branch directly but didn't merge this branch to master. I have just done
it. Anyway thanks for the push!


Reply to this email directly or view it on GitHub
#51 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants