Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fix a future depreciation. #12

Merged
merged 2 commits into from
Aug 14, 2022

Conversation

lvsantos1
Copy link
Contributor

Hey guys!

In PHP 8.2, which will be released on November 24th of this year, dynamic properties will be. The only change this pull request generates is the creation of a named property, which is used dynamically in the Google\CRC32\Builtin class.

Dynamic properties will be deprecated.
@bramp
Copy link
Collaborator

bramp commented Aug 14, 2022

Thank you, I noticed we are accidently using dynamic properties in other classes. Would you be able to fix them also?

@lvsantos1
Copy link
Contributor Author

Thank you, I noticed we are accidently using dynamic properties in other classes. Would you be able to fix them also?

Certainly. I'll go the changes in this branch, okay?

@bramp
Copy link
Collaborator

bramp commented Aug 14, 2022

Yes, all in this branch sounds great.

@bramp
Copy link
Collaborator

bramp commented Aug 14, 2022

Looks great! I would want to see a good set of tests run on Travis, but the integration with it seems broken :-/ (we haven't updated this repo in a while).

@bramp bramp merged commit bc27068 into google:master Aug 14, 2022
@lvsantos1
Copy link
Contributor Author

Looks great! I would want to see a good set of tests run on Travis, but the integration with it seems broken :-/ (we haven't updated this repo in a while)

Travis would be really good. Maybe next time?

From what I've seen here (https://travis-ci.org/github/google/php-crc32), a problem with code checking in 7.3 and a problem with the test run image in 5.4 and 5.5. Any need to maintain compatibility with 5.* versions?

@lvsantos1 lvsantos1 deleted the fixes-future-depreciations branch August 15, 2022 17:40
@jeremyhalin
Copy link

Hi, this hasn't been released, right ?

I have same issue that #13 in PHP 8.2

@jeremyhalin
Copy link

@bramp you closed the issue, but has it been released?

@bramp
Copy link
Collaborator

bramp commented Jan 25, 2023

@jeremyhalin you are correct, it's been fixed, but not released.

This was an unofficial side-project of mine, but if it's not possible to use the code from HEAD, then I'll look into releasing officially. Most likely this weekend I'll get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants