-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Fix a future depreciation. #12
Conversation
Dynamic properties will be deprecated.
Thank you, I noticed we are accidently using dynamic properties in other classes. Would you be able to fix them also? |
Certainly. I'll go the changes in this branch, okay? |
Yes, all in this branch sounds great. |
Looks great! I would want to see a good set of tests run on Travis, but the integration with it seems broken :-/ (we haven't updated this repo in a while). |
Travis would be really good. Maybe next time? From what I've seen here (https://travis-ci.org/github/google/php-crc32), a problem with code checking in 7.3 and a problem with the test run image in 5.4 and 5.5. Any need to maintain compatibility with 5.* versions? |
Hi, this hasn't been released, right ? I have same issue that #13 in PHP 8.2 |
@bramp you closed the issue, but has it been released? |
@jeremyhalin you are correct, it's been fixed, but not released. This was an unofficial side-project of mine, but if it's not possible to use the code from HEAD, then I'll look into releasing officially. Most likely this weekend I'll get a chance. |
Hey guys!
In PHP 8.2, which will be released on November 24th of this year, dynamic properties will be. The only change this pull request generates is the creation of a named property, which is used dynamically in the Google\CRC32\Builtin class.