Remove the dependency from lib.rs on web.rs #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaEvo
approved these changes
Mar 7, 2023
SilverBzH
reviewed
Mar 7, 2023
| path = "src/lib.rs" | ||
|
|
||
| [[bin]] | ||
| name = "server" |
There was a problem hiding this comment.
I am not a huge fan of naming the binary "server". This is too generic. Could we think about something else ?
There was a problem hiding this comment.
Sure, but it does not have to be very specific since we have only one binary.
There was a problem hiding this comment.
My main concern is mostly if the Pica Server is living in a bigger ecosystem, the word "server" would be too generic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Craft library interface #13 Make a clear separation between the library part of pica and the server runner, which is now composed of the previous main.rs and web.rs.
Issue Hyper dependency as a feature #9 Update the HTTP API by flattening event objects to make it simpler to remove the dependency on web.