Add support for Python 3 #19
Conversation
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
@zixia You may need to add a comment to this PR so that @googlebot can confirm you are ok with me publishing a change authored by you. |
|
@googlebot I'm ok with my commits being contributed to this project from @trein |
trein
force-pushed
the
feature_python3
branch
from
b2a87da
to
9942046
Compare
|
@trein Thank you very much that the Unite Tests under Python 2.7 seems that they had been fixed. The Python 3 had not passed yet, I had just fixed an Could you please have a look at them? We will be able to publish the new version to PyPI after we fixed all unit tests. And please feel free to let me know if we need to change any Travis CI settings. Cheers! |
trein
force-pushed
the
feature_python3
branch
from
4f4a380
to
c2cebb7
Compare
|
CLAs look good, thanks! |
trein
force-pushed
the
feature_python3
branch
from
c2cebb7
to
033943c
Compare
- Use Six package, a simple utilities for wrapping over differences between Python 2 and Python 3 - Encapsulate compatibility methods in 'support.py' module - Introduce unit tests for 'support.py' module
trein
force-pushed
the
feature_python3
branch
from
033943c
to
5107f91
Compare
|
Finally got all tests to pass. Not as easy as it seemed. Please, let me know your thoughts. |
|
Cheers! Will have a look into it tomorrow. |
|
Please, describe how to install it. Now I had to manually download |
|
@alexander-myltsev in the setup.py file you can remove the unused package dependency on pinject/third_party, which fixes your first problem. |
|
@rncry Good call. I will remove the reference to Update: I just noticed that you have a pull request for that. Thanks! |
|
@alexander-myltsev the second issue is probably due to your version of python not being built with correct support for gdbm/dbm. On mac you can do something like: $ brew uninstall python3 |
|
@huan how close is this to release? |
|
Hope I would have time to get this done tomorrow! |
|
Amazing :) thanks |
|
@huan just noticed my pr wasn't merged into this one.. setup.py will be broken(!) |
No description provided.