Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow applying google-services plugin in any order #61

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow applying google-services plugin in any order #61

wants to merge 3 commits into from

Conversation

technoir42
Copy link
Contributor

@technoir42 technoir42 commented Jun 11, 2019 •
edited

Makes it possible to apply google-services plugin on top of build.gradle without warning. Also simplifies Android plugin lookup and adds functional tests.

@technoir42 technoir42 force-pushed the apply-in-any-order branch 2 times, most recently from 04b7864 to 1ebf8ef Compare June 13, 2019 17:04
@technoir42
Copy link
Contributor Author

@davidmotson PTAL, I think this would be a nice improvement.

zhiqiao
zhiqiao reviewed Aug 23, 2019
View reviewed changes
Copy link
Contributor

@zhiqiao zhiqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Sorry it's taken us so long to get back to you.

Looks good from my end, but I want to make sure @davidmotson has a chance to weigh in.

Also, you may need to update this CL as per 3ad5395

@technoir42 technoir42 force-pushed the apply-in-any-order branch 15 times, most recently from 8931287 to b70cb66 Compare August 25, 2019 15:43
@technoir42
Copy link
Contributor Author

I rebased, added AGP 3.5.0 to test matrix, fixed Travis build and made Gradle console output more readable on Travis.

@technoir42 technoir42 mentioned this pull request Oct 29, 2019
Closed
@pgreze
Copy link

pgreze commented Apr 22, 2020

@zhiqiao or @davidmotson any news about this PR?
@technoir42 did a great job in this PR and 9 months passed without any review, which is fixing one of the most unnatural way to add a plugin ever.
I think I'm not alone looking forward to see this change merged ASAP 🙏

@lognaturel lognaturel mentioned this pull request Dec 6, 2020
Closed
@jakoss
Copy link

jakoss commented Oct 20, 2021

Is this topic dead? It seems like even Android Studio is moving to use plugins block by default (https://developer.android.com/studio/preview/features#settings-gradle) and yet this is untouched in 2 years now

@sagix
Copy link

sagix commented Apr 12, 2022

Hi, any news on this PR?

It would be nice to be able to apply this plugin like any other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqiao zhiqiao zhiqiao left review comments

@davidmotson davidmotson Awaiting requested review from davidmotson

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@technoir42 @pgreze @jakoss @sagix @zhiqiao