Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when service worker is not available #78

Closed
aomarks opened this issue Nov 11, 2020 · 1 comment · Fixed by #224
Closed

Warn when service worker is not available #78

aomarks opened this issue Nov 11, 2020 · 1 comment · Fixed by #224
Assignees
@aomarks

Comments

@aomarks
Copy link
Member

aomarks commented Nov 11, 2020

We should do this visibly in the element, not in the console.

Note that in Firefox, Service Workers are always disabled in private browsing mode.
@aomarks aomarks self-assigned this Nov 11, 2020
@aomarks
Copy link
Member Author

aomarks commented Oct 4, 2021

See https://bugzilla.mozilla.org/show_bug.cgi?id=1320796 for Firefox issue about service workers not being available in incognito mode.

@aomarks aomarks mentioned this issue Oct 4, 2021
Merged
aomarks added a commit that referenced this issue Oct 4, 2021
@aomarks
Show useful error when service workers unavailable (#224)
6e49bf1 
Detect when service workers are not available and show a useful error. Uses the same styling that we previously used on the main editor to prevent keyboard focus trap. The main place this comes up is when using Firefox in private browsing mode, which is not currently supported (see https://bugzilla.mozilla.org/show_bug.cgi?id=1320796).

Fixes #78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aomarks aomarks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show useful error when service workers unavailable google/playground-elements
1 participant
@aomarks