Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update node versions in tests #210

Merged
merged 2 commits into from
Apr 29, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@ jobs:
test-linux:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
node: [ 10, 12, 14, 15, 16]
node: [ 12, 14, 16, 17, 18 ]
amchiclet marked this conversation as resolved.
Show resolved Hide resolved
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"delay": "^5.0.0",
"findit2": "^2.2.3",
"nan": "^2.14.0",
"@mapbox/node-pre-gyp": "^1.0.0",
"@mapbox/node-pre-gyp": "^1.0.9",
"p-limit": "^3.0.0",
"pify": "^5.0.0",
"protobufjs": "~6.11.0",
Expand Down
14 changes: 0 additions & 14 deletions system-test/Dockerfile.node15-alpine

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ WORKDIR /root/
RUN go get github.com/google/pprof


FROM node:10-alpine
FROM node:17-alpine

ARG ADDITIONAL_PACKAGES

Expand Down
18 changes: 9 additions & 9 deletions system-test/system_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,15 @@ set -eox pipefail

cd $(dirname $0)

# The list of tested versions below should be in sync with node's
# official releases. https://nodejs.org/en/about/releases/
if [[ -z "$BINARY_HOST" ]]; then
ADDITIONAL_PACKAGES="python3 g++ make"
NODE_VERSIONS=(10 12 14 15 16 node)
NODE_VERSIONS=(12 14 16 17 18 node)
else
NODE_VERSIONS=(10 12 14 15 16)
# Tested versions for pre-built binaries are limited based on
# what node-pre-gyp can specify as its target version.
NODE_VERSIONS=(12 14 16 17)
fi

for i in ${NODE_VERSIONS[@]}; do
Expand All @@ -26,13 +30,9 @@ for i in ${NODE_VERSIONS[@]}; do
docker run -v $PWD/..:/src -e BINARY_HOST="$BINARY_HOST" node$i-linux \
/src/system-test/test.sh

# Test support for accurate line numbers with node versions supporting this
# feature.
if [ "$i" != "10" ]; then
docker run -v $PWD/..:/src -e BINARY_HOST="$BINARY_HOST" \
-e VERIFY_TIME_LINE_NUMBERS="true" node$i-linux \
/src/system-test/test.sh
fi
docker run -v $PWD/..:/src -e BINARY_HOST="$BINARY_HOST" \
-e VERIFY_TIME_LINE_NUMBERS="true" node$i-linux \
/src/system-test/test.sh

# Test Alpine support for the given node version.
retry docker build -f Dockerfile.node$i-alpine \
Expand Down
2 changes: 1 addition & 1 deletion tools/build/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ mkdir -p "$ARTIFACTS_OUT"

npm install --quiet

for version in 10.0.0 12.0.0 14.0.0 15.0.0 16.0.0
for version in 12.0.0 14.0.0 16.0.0 17.0.1
do
./node_modules/.bin/node-pre-gyp configure rebuild package \
--target=$version --target_arch="x64"
Expand Down