Skip to content

Commit

Permalink
internal/driver: skip TestHttpsInsecure test on iOS
Browse files Browse the repository at this point in the history
This will in turn fix golang.org/issues/22612 for the Go iOS
builders.
  • Loading branch information
Elias Naur committed Nov 8, 2017
1 parent 79c4198 commit 40c2029
Showing 1 changed file with 13 additions and 2 deletions.
15 changes: 13 additions & 2 deletions internal/driver/fetch_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -411,9 +411,14 @@ func TestHttpsInsecure(t *testing.T) {
Timeout: 10,
Symbolize: "remote",
}
rx := "Saved profile in"
if runtime.GOOS == "darwin" && (runtime.GOARCH == "arm" || runtime.GOARCH == "arm64") {
// On iOS, $HOME points to the app root directory and is not writable.
rx += "|Could not use temp dir"
}
o := &plugin.Options{
Obj: &binutils.Binutils{},
UI: &proftest.TestUI{T: t, AllowRx: "Saved profile in"},
UI: &proftest.TestUI{T: t, AllowRx: rx},
}
o.Sym = &symbolizer.Symbolizer{Obj: o.Obj, UI: o.UI}
p, err := fetchProfiles(s, o)
Expand All @@ -423,9 +428,15 @@ func TestHttpsInsecure(t *testing.T) {
if len(p.SampleType) == 0 {
t.Fatalf("fetchProfiles(%s) got empty profile: len(p.SampleType)==0", address)
}
if runtime.GOOS == "plan9" {
switch runtime.GOOS {
case "plan9":
// CPU profiling is not supported on Plan9; see golang.org/issues/22564.
return
case "darwin":
if runtime.GOARCH == "arm" || runtime.GOARCH == "arm64" {
// CPU profiling on iOS os not symbolized; see golang.org/issues/22612.
return
}
}
if len(p.Function) == 0 {
t.Fatalf("fetchProfiles(%s) got non-symbolized profile: len(p.Function)==0", address)
Expand Down

0 comments on commit 40c2029

Please sign in to comment.