Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for debug symbols in binutils-type build-id directories #473

Closed
rjogrady opened this issue Jun 4, 2019 · 2 comments
Closed

Look for debug symbols in binutils-type build-id directories #473

rjogrady opened this issue Jun 4, 2019 · 2 comments
Labels
type: feat Buganizer type - Feature Request

Comments

@rjogrady
Copy link

rjogrady commented Jun 4, 2019

Please answer these questions before submitting your issue. Thanks!

What version of pprof are you using?

b4f4732 (2018-11-28)
If you are using pprof via go tool pprof, what's your go env output?
N/A
If you run pprof from GitHub, what's the Git revision?
N/A

What operating system and processor architecture are you using?

Linux 64-bit

When symbolizing, pprof already looks for elfs in a variety of places, such as
$PPROF_BINARY_PATH/<build_id>, $PPROF_BINARY_PATH/<build_id>/<binary_name>,
etc.

The debug info extracted from debian packages is stored in files called usr/lib/debug/.build-id/build_id[:2]/build_id[2:].debug
e.g.
/usr/lib/debug/.build-id/2b/c3a6cf803d6dc59ec11f2773e1b4a795008dbf.debug is the debug elf corresponding to an elf with build-id 2bc3a6cf803d6dc59ec11f2773e1b4a795008dbf

So for symbolizing when we have the debug symbols separate from the stripped shared library, it would be helpful if pprof could try to locate these as well, e.g by searching for
$PPROF_BINARY_PATH/ab/cdefgh.debug

@aalexand
Copy link
Collaborator

aalexand commented Jun 4, 2019

@rjogrady - please feel free to send a PR.

@aalexand
Copy link
Collaborator

aalexand commented May 2, 2023

I think this is fixed by #724.

@aalexand aalexand closed this as completed May 2, 2023
@aalexand aalexand added type: feat Buganizer type - Feature Request and removed enhancement labels May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feat Buganizer type - Feature Request
Projects
None yet
Development

No branches or pull requests

3 participants