Add new symbol directory layout by build-id /xx/xxxxxxxx.debug.
#724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #724 +/- ##
=======================================
Coverage 64.67% 64.68%
=======================================
Files 45 45
Lines 6602 6603 +1
=======================================
+ Hits 4270 4271 +1
Misses 1884 1884
Partials 448 448
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
aalexand
reviewed
Sep 26, 2022
aalexand
previously approved these changes
Sep 29, 2022
|
@piwicode CI fails due to wrong source code formatting. |
This protocol is already supported by various tools and lldb. e.g.: https://github.com/llvm-mirror/lldb/blob/d01083a850f577b85501a0902b52fd0930de72c7/source/Symbol/LocateSymbolFile.cpp#L311 Among others it is used by Fuchisa OS builds.
|
This should be fine now. Thanks. |
aalexand
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This protocol is already supported by various tools and lldb. e.g.: https://github.com/llvm-mirror/lldb/blob/d01083a850f577b85501a0902b52fd0930de72c7/source/Symbol/LocateSymbolFile.cpp#L311
Among others it is used by Fuchisa OS builds.
This change was unit tested with
fetch_test.go.It was manually tested with a FuchsaOS build by pointing pprof at
$FUCHSIA_HOME/out/default/.build-id