-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No warning if filter argument has no matches. #629
Comments
prattmic
added a commit
to prattmic/pprof
that referenced
this issue
May 11, 2021
list, weblist, disasm, and peek all take a regexp argument that acts as a filter. Currently if this filter results in no matches we simply generate an empty report, which can be confusing to users. Instead, explicitly treat this as an error condition that is clearly reported to users. Fixes google#629
prattmic
added a commit
to prattmic/pprof
that referenced
this issue
Jul 13, 2021
list, weblist, disasm, and peek all take a regexp argument that acts as a filter. Currently if this filter results in no matches we simply generate an empty report, which can be confusing to users. Instead, explicitly treat this as an error condition that is clearly reported to users. Fixes google#629
aalexand
pushed a commit
that referenced
this issue
Jul 15, 2021
list, weblist, disasm, and peek all take a regexp argument that acts as a filter. Currently if this filter results in no matches we simply generate an empty report, which can be confusing to users. Instead, explicitly treat this as an error condition that is clearly reported to users. Fixes #629
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please answer these questions before submitting your issue. Thanks!
What version of pprof are you using?
If you are using pprof via
go tool pprof
, what's yourgo env
output?If you run pprof from GitHub, what's the Git revision?
923b5ab (latest HEAD)
What operating system and processor architecture are you using?
Linux, amd64
What did you do?
If possible, provide a recipe for reproducing the error.
Attaching a profile you are trying to analyze is good.
Attempt to
disasm
,list
,peek
a symbol that doesn't exist.What did you expect to see?
An explanation that there are no matching symbols. Something like:
What did you see instead?
To a user that doesn't fully understand this behavior, it is rather confusing to only get a "total" with no other output.
Note that commands with a focus argument do display a warning (in red):
I can send a simple CL to add a warning to the few commands with an argument.
The text was updated successfully, but these errors were encountered: