Create a fake mapping for profile.proto profiles #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a profile has mappings but no profiles, pprof may be unable to symbolize it offline, as it uses the mappings to keep track of which locations need symbolization. This fixes google#120. Added the test, verified it fails on Mac with Go 1.7 before the fix, and passes with the fix. The test is done by augmenting the existing test for handling https+insecure:// schema in URLs. This is a bit vague but I figured that this test needed an updated anyway since as we moved it recently we stopped exercising the symbolization as part of the test which was its original intention in fixing google#94. Can split the tests if things do look too ugly.
tamird
reviewed
Apr 18, 2017
internal/proftest/proftest.go
Outdated
| if ui.IgnoreRx != "" { | ||
| if matched, err := regexp.MatchString(ui.IgnoreRx, fmt.Sprint(args)); matched || err != nil { | ||
| if err != nil { | ||
| ui.T.Error(args) |
There was a problem hiding this comment.
this should probably also include the error.
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
=========================================
+ Coverage 54.59% 54.9% +0.31%
=========================================
Files 29 29
Lines 5697 5697
=========================================
+ Hits 3110 3128 +18
+ Misses 2251 2230 -21
- Partials 336 339 +3
Continue to review full report at Codecov.
|
aalexand
force-pushed
the
aalexand-fix-no-mappings
branch
from
53204fa
to
1c8f1ab
Compare
nolanmar511
added a commit
to nolanmar511/pprof
that referenced
this pull request
Jul 20, 2017
This reverts commit 1047541.
nolanmar511
added a commit
to nolanmar511/pprof
that referenced
this pull request
Jul 20, 2017
This reverts commit 1047541.
gmarin13
pushed a commit
to gmarin13/pprof
that referenced
this pull request
Dec 17, 2020
* Create a fake mapping for profile.proto profiles If a profile has mappings but no profiles, pprof may be unable to symbolize it offline, as it uses the mappings to keep track of which locations need symbolization. This fixes google#120. Added the test, verified it fails on Mac with Go 1.7 before the fix, and passes with the fix. The test is done by augmenting the existing test for handling https+insecure:// schema in URLs. This is a bit vague but I figured that this test needed an updated anyway since as we moved it recently we stopped exercising the symbolization as part of the test which was its original intention in fixing google#94. Can split the tests if things do look too ugly. * Fix the test to include the failed regex matching error in the message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a profile has mappings but no profiles, pprof may be unable to
symbolize it offline, as it uses the mappings to keep track of which
locations need symbolization.
This fixes #120.
Added the test, verified it fails on Mac with Go 1.7 before the fix, and
passes with the fix. The test is done by augmenting the existing test
for handling https+insecure:// scheme in URLs. This is a bit vague but I
figured that this test needed an updated anyway since as we moved it
recently we stopped exercising the symbolization as part of the test
which was its original intention in fixing #94. Can split the tests if
things do look too ugly.