Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to reflect the changes for the -http flag #180

Merged
merged 1 commit into from
Aug 8, 2017

Conversation

rakyll
Copy link

@rakyll rakyll commented Aug 1, 2017

Docs are stale, -http flag now supports host:port.

Docs are stale, -http flag now supports host:port.
@codecov-io
Copy link

codecov-io commented Aug 1, 2017

Codecov Report

Merging #180 into master will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #180     +/-   ##
=========================================
- Coverage   54.42%   54.23%   -0.2%     
=========================================
  Files          32       32             
  Lines        6355     6186    -169     
=========================================
- Hits         3459     3355    -104     
+ Misses       2535     2470     -65     
  Partials      361      361
Impacted Files Coverage Δ
internal/driver/cli.go 77.2% <ø> (ø) ⬆️
profile/prune.go 72% <0%> (-0.35%) ⬇️
profile/merge.go 85.77% <0%> (+0.89%) ⬆️
profile/profile.go 61.88% <0%> (+2.91%) ⬆️
profile/proto.go 83.25% <0%> (+3.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40f98f8...49d97c3. Read the comment docs.

Copy link
Collaborator

@aalexand aalexand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be a bit more convenient if we treated -http as "localhost:" when just "" is specified.

@rakyll
Copy link
Author

rakyll commented Aug 1, 2017

Sounds good to support "" as -http. I will send a PR for that.

@rakyll
Copy link
Author

rakyll commented Aug 8, 2017

@aalexand, can you merge this change? I don't have the privileges to do it myself.

@nolanmar511 nolanmar511 merged commit d127b8f into google:master Aug 8, 2017
@rakyll rakyll mentioned this pull request Aug 21, 2017
gmarin13 pushed a commit to gmarin13/pprof that referenced this pull request Dec 17, 2020
Docs are stale, -http flag now supports host:port.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants