Enable MacOS binutils test. #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
=========================================
+ Coverage 65.8% 66.5% +0.69%
=========================================
Files 36 36
Lines 7429 7431 +2
=========================================
+ Hits 4889 4942 +53
+ Misses 2142 2085 -57
- Partials 398 404 +6
Continue to review full report at Codecov.
|
nolanmar511
approved these changes
Feb 14, 2018
internal/binutils/addr2liner.go
Outdated
| // character insignificant to avoid replacing foo with _foo on MacOS (for | ||
| // unknown reasons read2line produces the former and nm produces the | ||
| // latter on MacOS even though both tools are asked to produce mangled | ||
| // names. |
There was a problem hiding this comment.
Missing close parenthesis to match (for on line 229, I think.
aalexand
force-pushed
the
osx-binutils-test
branch
from
34fe63a
to
cd7e3f2
Compare
gmarin13
pushed a commit
to gmarin13/pprof
that referenced
this pull request
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up the unfinished test in #313.