Allow serving web ui at arbitrary root #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbg
force-pushed
the
fix/browser
branch
2 times, most recently
from
ec2bb92
to
4b10bf3
Compare
aalexand
reviewed
Mar 31, 2018
internal/driver/webui.go
Outdated
|
|
||
| mux := http.NewServeMux() | ||
| mux.Handle("/ui/", http.StripPrefix("/ui", handler)) | ||
| mux.Handle("/", http.RedirectHandler("/ui/", http.StatusTemporaryRedirect)) |
There was a problem hiding this comment.
I'd add a comment on why the redirect is done.
|
@tschottdorf Added a small comment. I agree #208 is overdue. |
Previously, the web UI was hard-coded to be served at `/` but applications which are *embedding* the ui are unlikely to host it there. This change makes the links between the various ui pages relative, addressing this problem. To make sure this doesn't rot, the internal http server now serves the ui at /ui/ (redirecting there from the root). I think we can all agree that the ui code and JavaScript is kind of a haphazard affair. I performed a great deal of clicking around to make sure the semantics didn't change and interestingly spent some time trying to fix semantics I later realized weren't actually there: I thought that when navigating to another page from a focused search (say `flamegraph?f=x`) the focus would be carried over. This doesn't seem to be the case, however. The point being, there's no test coverage and setting it up is way beyond what I can do here. I'm happy to manually verify whatever sequence of clicks is suggested, though. Touches cockroachdb/cockroach#24145.
|
Thanks for the review, added the comment. |
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
==========================================
- Coverage 66.55% 66.52% -0.04%
==========================================
Files 36 36
Lines 7439 7441 +2
==========================================
- Hits 4951 4950 -1
- Misses 2084 2087 +3
Partials 404 404
Continue to review full report at Codecov.
|
aalexand
approved these changes
Mar 31, 2018
gmarin13
pushed a commit
to gmarin13/pprof
that referenced
this pull request
Dec 17, 2020
Previously, the web UI was hard-coded to be served at `/` but applications which are *embedding* the ui are unlikely to host it there. This change makes the links between the various ui pages relative, addressing this problem. To make sure this doesn't rot, the internal http server now serves the ui at /ui/ (redirecting there from the root). I think we can all agree that the ui code and JavaScript is kind of a haphazard affair. I performed a great deal of clicking around to make sure the semantics didn't change and interestingly spent some time trying to fix semantics I later realized weren't actually there: I thought that when navigating to another page from a focused search (say `flamegraph?f=x`) the focus would be carried over. This doesn't seem to be the case, however. The point being, there's no test coverage and setting it up is way beyond what I can do here. I'm happy to manually verify whatever sequence of clicks is suggested, though. Touches cockroachdb/cockroach#24145.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the web UI was hard-coded to be served at
/butapplications which are embedding the ui are unlikely to host it there.
This change makes the links between the various ui pages relative,
addressing this problem.
To make sure this doesn't rot, the internal http server now serves the
ui at /ui/ (redirecting there from the root).
I think we can all agree that the ui code and JavaScript is kind of a
haphazard affair. I performed a great deal of clicking around to make
sure the semantics didn't change and interestingly spent some time
trying to fix semantics I later realized weren't actually there: I
thought that when navigating to another page from a focused search (say
flamegraph?f=x) the focus would be carried over. This doesn't seem tobe the case, however.
The point being, there's no test coverage and setting it up is way
beyond what I can do here. I'm happy to manually verify whatever
sequence of clicks is suggested, though.
Touches cockroachdb/cockroach#24145.