Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay base computation for ELF files until we have a sample address. #623

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

gmarin13
Copy link
Contributor

We can use the sample's offset into the mapping to differentiate between small
segments that are in the same file page when associating a segment with the
mapping.

@gmarin13 gmarin13 requested a review from aalexand April 13, 2021 17:20
@google-cla google-cla bot added the cla: yes label Apr 13, 2021
@codecov-io
Copy link

codecov-io commented Apr 13, 2021

Codecov Report

Merging #623 (4b38d16) into master (7c2eacd) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #623      +/-   ##
==========================================
- Coverage   66.94%   66.85%   -0.10%     
==========================================
  Files          39       39              
  Lines        7195     7226      +31     
==========================================
+ Hits         4817     4831      +14     
- Misses       1942     1954      +12     
- Partials      436      441       +5     
Impacted Files Coverage Δ
...ithub.com/google/pprof/internal/elfexec/elfexec.go 40.62% <0.00%> (-2.86%) ⬇️
...hub.com/google/pprof/internal/binutils/binutils.go 46.23% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c2eacd...4b38d16. Read the comment docs.

We can use the sample's offset into the mapping to differentiate between small
segments that are in the same file page when associating a segment with the
mapping.
@gmarin13
Copy link
Contributor Author

Updated the code. PTAL.

@gmarin13
Copy link
Contributor Author

All the checks pass after the Golang runtime fix.

@aalexand aalexand merged commit a266312 into google:master Apr 23, 2021
@gmarin13 gmarin13 deleted the delay_base branch July 20, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants